Skip to content

♿ Improved transactional email footer text contrast - #29680

Closed
jatinder14 wants to merge 1 commit into
TryGhost:mainfrom
jatinder14:fix/transactional-email-footer-contrast
Closed

♿ Improved transactional email footer text contrast#29680
jatinder14 wants to merge 1 commit into
TryGhost:mainfrom
jatinder14:fix/transactional-email-footer-contrast

Conversation

@jatinder14

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Spot-check magic-link / invite / password-reset HTML footers for `#5B6B73`
  • Confirm CI snapshot updates pass

Closes #29679
Related to #29666

Made with Cursor

Replace #738A94 with #5B6B73 across transactional email templates so
footer text meets WCAG 1.4.3, matching the newsletter footer fix.

Closes #29679
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3416025a-33cb-4ba8-8871-78550ea79260

📥 Commits

Reviewing files that changed from the base of the PR and between e1d00a5 and ec16e8d.

⛔ Files ignored due to path filters (5)
  • ghost/core/test/e2e-api/admin/__snapshots__/members.test.js.snap is excluded by !**/*.snap
  • ghost/core/test/e2e-api/admin/__snapshots__/newsletters.test.js.snap is excluded by !**/*.snap
  • ghost/core/test/e2e-api/members/__snapshots__/send-magic-link.test.js.snap is excluded by !**/*.snap
  • ghost/core/test/legacy/api/admin/__snapshots__/authentication.test.js.snap is excluded by !**/*.snap
  • ghost/core/test/unit/server/services/settings/__snapshots__/settings-bread-service.test.js.snap is excluded by !**/*.snap
📒 Files selected for processing (24)
  • ghost/core/core/server/data/importer/email-template.ts
  • ghost/core/core/server/services/auth/session/emails/signin.js
  • ghost/core/core/server/services/comments/email-templates/new-comment-reply.hbs
  • ghost/core/core/server/services/comments/email-templates/new-comment.hbs
  • ghost/core/core/server/services/comments/email-templates/report.hbs
  • ghost/core/core/server/services/gifts/email-templates/gift-purchase-confirmation.hbs
  • ghost/core/core/server/services/gifts/email-templates/gift-reminder.hbs
  • ghost/core/core/server/services/mail/templates/invite-user-by-api-key.html
  • ghost/core/core/server/services/mail/templates/invite-user.html
  • ghost/core/core/server/services/mail/templates/notification.html
  • ghost/core/core/server/services/mail/templates/reset-password.html
  • ghost/core/core/server/services/mail/templates/welcome.html
  • ghost/core/core/server/services/members/emails/signin.js
  • ghost/core/core/server/services/members/emails/signup-paid.js
  • ghost/core/core/server/services/members/emails/signup.js
  • ghost/core/core/server/services/members/emails/subscribe.js
  • ghost/core/core/server/services/members/emails/update-email.js
  • ghost/core/core/server/services/members/import-export/import/email-template.js
  • ghost/core/core/server/services/newsletters/emails/verify-email.js
  • ghost/core/core/server/services/settings/emails/verify-email.js
  • ghost/core/core/server/services/staff/email-templates/new-milestone-received.hbs
  • ghost/core/test/unit/server/services/comments/comments-service-emails-renderer.test.js
  • ghost/core/test/unit/server/services/lib/email-content-generator.test.js
  • ghost/core/test/unit/server/services/lib/fixtures/templates/welcome.html

Walkthrough

Transactional email templates replace footer and link color #738A94 with #5B6B73. Several templates also add class="small" or adjust inline verification-email styles. Notification blockquote styling is updated, and unit-test expectations plus a welcome-email fixture reflect the new rendered color.

Possibly related PRs

Suggested labels: ok to merge for me

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR also changes non-footer styling, including a blockquote border and URL typography, which are outside the requested footer color swap. Split unrelated styling tweaks into a separate PR or remove them if they weren't intended.
Linked Issues check ❓ Inconclusive Template updates match the issue, but matching .snap files were excluded, so snapshot compliance can't be verified. Provide the excluded snapshot diffs or include the .snap files in review so the snapshot requirement can be verified.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed Clearly describes the main change: improving transactional email footer contrast.
Description check ✅ Passed Directly related to the color and snapshot updates described in the PR.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[a11y] Transactional email footer text doesn't have enough contrast

2 participants