This repository was archived by the owner on Jan 7, 2022. It is now read-only.
selectros for unregistered communities and change logic in launch sag…#90
Open
Dinek007 wants to merge 1 commit into
Open
selectros for unregistered communities and change logic in launch sag…#90Dinek007 wants to merge 1 commit into
Dinek007 wants to merge 1 commit into
Conversation
holmesworcester
left a comment
holmesworcester
left a comment
There was a problem hiding this comment.
I didn't totally get what's happening here. Why do we have to check multiple communities?
| import { identitySelectors } from './identity.selectors'; | ||
| import { Identity, identityReducer, IdentityState } from './identity.slice'; | ||
|
|
||
| describe('communitiesSelectors', () => { |
There was a problem hiding this comment.
Is there a more readable description that would be appropriate here? What are we checking?
|
|
||
| describe('communitiesSelectors', () => { | ||
| let store: Store; | ||
| const communityAlpha: Community = { |
There was a problem hiding this comment.
Are these different users or different communities? Why are we testing with different communities?
| port: 0, | ||
| }; | ||
|
|
||
| const identityAlpha: Identity = { |
There was a problem hiding this comment.
Are these users? If so, should we just call them users?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…a init