Skip to content

Improve timeout handling in IPFSBlockStorage methods #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrastaea merged 1 commit into from
Jul 9, 2026
Merged

Improve timeout handling in IPFSBlockStorage methods #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/storage/ipfs-block.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,12 @@ const IPFSBlockStorage = async ({ ipfs, pin, timeout } = {}) => {
*/
const put = async (hash, data) => {
const cid = CID.parse(hash, base58btc)
const { signal } = new TimeoutController(timeout || DefaultTimeout)
await ipfs.blockstore.put(cid, data, { signal })
const timeoutController = new TimeoutController(timeout || DefaultTimeout)
try {
await ipfs.blockstore.put(cid, data, { signal: timeoutController.signal })
} finally {
timeoutController.clear()
}

if (pin && !(await ipfs.pins.isPinned(cid))) {
await drain(ipfs.pins.add(cid))
Expand All @@ -58,10 +62,14 @@ const IPFSBlockStorage = async ({ ipfs, pin, timeout } = {}) => {
*/
const get = async (hash) => {
const cid = CID.parse(hash, base58btc)
const { signal } = new TimeoutController(timeout || DefaultTimeout)
const block = await ipfs.blockstore.get(cid, { signal })
if (block) {
return block
const timeoutController = new TimeoutController(timeout || DefaultTimeout)
try {
const block = await ipfs.blockstore.get(cid, { signal: timeoutController.signal })
if (block) {
return block
}
} finally {
timeoutController.clear()
}
}

Expand Down
Loading