[codex] fix channel metadata validation#3306
Draft
holmesworcester wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This closes the forged channel metadata hole by validating decrypted channel metadata against the signer, key, encryption scope, and deterministic role naming before indexing a channel metadata PUT.
What changed
userIdto match the payload signature author and active team.memberrole and not declare a channel role.memberIds, signed by a participant, and encrypted to the deterministic DM role for those participants.Validation
npm run lint:no-fix -- src/nest/storage/channels/channels.service.ts src/nest/storage/channels/channels.service.spec.tsnpm run build -- --pretty falseNODE_OPTIONS="--experimental-vm-modules" DEBUG=ipfs:*,backend:* npx -y node@20.20.1 node_modules/jest/bin/jest.js --runInBand --verbose --testPathIgnorePatterns=".src/(!?nodeTest*)|(.node_modules*)" --detectOpenHandles --forceExit src/nest/storage/channels/channels.service.spec.tsNote: running the same Jest command through the local default Node
v24.13.0fails duringSigChainService.createChain()setup with amsgpackrRangeError. The repo pins Node20.20.1; the focused spec passes under that version.