feat(3354): Randomly generate private channel role names#3355
Open
islathehut wants to merge 15 commits into
Open
feat(3354): Randomly generate private channel role names#3355islathehut wants to merge 15 commits into
islathehut wants to merge 15 commits into
Conversation
…ship in UI (desktop)
…ivate-channels-admin-only
islathehut
changed the title
…edux' into feat/3354-randomly-generated-private-channel-role-names
adrastaea
requested changes
Jul 17, 2026
adrastaea
left a comment
adrastaea
left a comment
Collaborator
There was a problem hiding this comment.
one type issue, but otherwise fine.
| @@ -93,6 +95,12 @@ class UserService extends ChainServiceBase { | |||
| return users[0] | |||
Collaborator
There was a problem hiding this comment.
This can return undefined as long as throwOnMissing is not true, so the type definition for the returned value is incorrect. Same with getMyUser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: