Harden Tor iOS lifecycle#3356
Open
adrastaea wants to merge 18 commits into
Open
Conversation
* Update directory to Quiet8 and files7 to files8 * Update CHANGELOG
* Update s3 bucket for 8.0 * Update CHANGELOG
- Added a new function `getMessageEnvelopeLogMetadata` to extract metadata from message envelopes for improved logging. - Updated logging in `MessageCodec` to provide more detailed information during payload parsing and envelope deserialization. - Refactored `startNodeProject` method in `RNNodeJsMobile` to run the Node project in the background, preventing UI blocking. - Adjusted `launchBackend` in `AppDelegate` to utilize the new background startup method. - Updated Podfile.lock to reflect changes in Yoga dependency version. - Modified Xcode project settings to ensure proper framework linking and resource management. - Enhanced `TorHandler` to include a list of directory authorities for improved bootstrap independence.
adrastaea
marked this pull request as ready for review
July 14, 2026 16:01
islathehut
reviewed
Jul 15, 2026
| await this.spawnHiddenServices() | ||
| if (bootstrapGeneration !== this.bootstrapGeneration) return | ||
| await this.spawnHiddenServices(bootstrapGeneration) | ||
| if (bootstrapGeneration !== this.bootstrapGeneration) { |
Collaborator
There was a problem hiding this comment.
Should this now be removed since we do this check before the spawn now?
| import type { OpenServices } from './options' | ||
|
|
||
| export type MobileLifecycleIntent = | ||
| | { type: 'paused' } |
Collaborator
There was a problem hiding this comment.
Nitpick but can you create and use an enum for the intent types rather than just setting 'paused' and 'active'?
islathehut
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: