Fixed issue with naming and added support for update - #14
Conversation
ArturMarschal
commented
Nov 14, 2025
ArturMarschal
commented
- fixed special charachter issue with reminder and role token naming
- added new features to update
- added built-in json instead of normal url, as BotC webpage changed
- added bloodstar-url option, to be able to use tool with homebrew scripts easily
- added small change to name and ability texts, to be able to handle special charcters better, now only ő and ű
- added id for roles, to avoid issue with naming, from now on id is used for token names, not the name, so it is possible to keep id in english but name in localized text
* fixed special charachter issue with reminder and role token naming
* added new features to update
* added built-in json instead of normal url, as BotC webpage changed
* added bloodstar-url option, to be able to use tool with homebrew
scripts easily
* added small change to name and ability texts, to be able to handle
special charcters better, now only ő and ű
* added id for roles, to avoid issue with naming, from now on id is used
for token names, not the name, so it is possible to keep id in english
but name in localized text
|
Also, could you target the dev branch instead of stable? I use stable to track releases. Thanks for your submission! |
|
Awesome, I'll review these tomorrow and merge it in if everything looks good. |
Tsubashi
left a comment
Tsubashi
left a comment
There was a problem hiding this comment.
Don't forget to run the linter as well. Right now there are a few linter issues (line length, import order, etc).
Thanks for your contribution, and thanks for being cool with my nitpicks. If it gets to be too much just let me know and I can merge it and clean it up myself.
Again, thanks for making this tool even better!
| if meta_data: | ||
| version_name = meta_data.get('name') | ||
| else: | ||
| print(f"[yellow]Warning:[/] Could not find metadata for the script") |
There was a problem hiding this comment.
Looks like we are missing test coverage on this line. Please add a test that attempts to load a script without metadata.
| f"\n\nI will continue, but [yellow]be warned that it might not work[/].") | ||
| wiki.role_data = custom_list | ||
| if custom_list.startswith("https://"): | ||
| wiki.load_from_web_json(custom_list) |
There was a problem hiding this comment.
I think we should still apply validation whether using local files or URLs. Right now it is being bypassed when using URLs.
|
Sorry, but I did not have time to complete it, but now I think everything has been addressed. Only thing is, that when I added validation to the schema, it already warns, that _meta must be there, so I have removed redundant warning message. Please review. (Btw Im not a python guy, so I'm just trying my best) |
2 participants
