Clean up scaffolding: remove FINDINGS, shims, legacy task installer - #3
Merged
Conversation
…tall-task.ps1 Files removed: - FINDINGS.md — pre-build research notes referencing unrelated repos (gv-worker, PrintNode, CloudConvert) that aren't part of mailpress - install-task.ps1 — the wizard installs the Scheduled Task itself now via lib/task.mjs - index.mjs — back-compat shim. cli.mjs is the single entry point. - consent.mjs — back-compat shim. `mailpress --consent` replaces it. Source-mode Scheduled Task target switched from `node index.mjs` to `node cli.mjs`. cli.mjs now detects non-TTY (Scheduled Task) and exits with a helpful message + exit code 2 instead of trying to launch the interactive wizard, so a misconfigured task won't hang on stdin. Build + workflow artifact lists updated. README's "Install" + "from source" + "Architecture" sections reflect the new layout. Stale comments in print-files.ps1 and lib/poll.mjs updated. Top-level layout after cleanup: cli.mjs # entry point lib/*.mjs # all code print-files.ps1 # print helper (ships with the exe) config.example.json # template assets/ # icon source + .ico scripts/build.mjs # SEA build .github/workflows/ # CI https://claude.ai/code/session_01CfsRS2PZ4t8RUnhPdVEWHF
Turetsky
added a commit
that referenced
this pull request
May 26, 2026
Files removed: - FINDINGS.md — pre-build research notes referencing unrelated repos (gv-worker, PrintNode, CloudConvert) that aren't part of mailpress - install-task.ps1 — the wizard installs the Scheduled Task itself now via lib/task.mjs - index.mjs — back-compat shim. cli.mjs is the single entry point. - consent.mjs — back-compat shim. `mailpress --consent` replaces it. Source-mode Scheduled Task target switched from `node index.mjs` to `node cli.mjs`. cli.mjs now detects non-TTY (Scheduled Task) and exits with a helpful message + exit code 2 instead of trying to launch the interactive wizard, so a misconfigured task won't hang on stdin. Build + workflow artifact lists updated. README's "Install" + "from source" + "Architecture" sections reflect the new layout. Stale comments in print-files.ps1 and lib/poll.mjs updated. Top-level layout after cleanup: cli.mjs # entry point lib/*.mjs # all code print-files.ps1 # print helper (ships with the exe) config.example.json # template assets/ # icon source + .ico scripts/build.mjs # SEA build .github/workflows/ # CI https://claude.ai/code/session_01CfsRS2PZ4t8RUnhPdVEWHF Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes scaffolding cruft and consolidates around the single entry point.
Deleted files
FINDINGS.md— pre-build research notes referencing repos / services not part of mailpress (gv-worker, PrintNode, CloudConvert)install-task.ps1— the wizard installs the Scheduled Task itself vialib/task.mjsindex.mjs— back-compat shim;cli.mjsis the single entry pointconsent.mjs— back-compat shim;mailpress --consentdoes the sameCode adjustments to support removal
lib/task.mjs: source-mode Scheduled Task target switched fromnode index.mjstonode cli.mjscli.mjs: detects non-TTY (Scheduled Task) and exits cleanly with code 2 + a helpful message instead of trying to launch the interactive wizard. Verified:mailpress < /dev/null→ exit 2 with"there is no terminal to run the wizard in".Layout after cleanup (5 top-level files + 4 dirs):
Test plan
node cli.mjs --helpbootsmailpress --doctorfrom a clean dir reports correct statusmailpress < /dev/null(non-TTY) exits 2 with helpful message instead of hanging on promptnode scripts/build.mjsproduces a working binary; dist listing no longer includes install-task.ps1https://claude.ai/code/session_01CfsRS2PZ4t8RUnhPdVEWHF
Generated by Claude Code