File audit + one-file install bundle (mailpress-installer.zip) - #4
Closed
Turetsky wants to merge 2 commits into
Closed
File audit + one-file install bundle (mailpress-installer.zip)#4Turetsky wants to merge 2 commits into
Turetsky wants to merge 2 commits into
Conversation
Audit: only one file in the repo wasn't earning its keep —
assets/icon-preview-256.png was generated once for documentation and
never used by build or runtime. Removed. Everything else (cli.mjs,
lib/* x11, print-files.ps1, config.example.json, assets/icon.{svg,ico},
scripts/build.mjs, .github/workflows/release.yml) has a clear role and
stays.
Installer bundle:
- scripts/build.mjs now also writes dist/INSTALL.txt — plain-text
step-by-step install guide + command reference, so anyone who unzips
the bundle has everything they need on paper without internet.
- .github/workflows/release.yml zips dist/ into mailpress-installer.zip
(PowerShell Compress-Archive) and attaches it to both the workflow
artifact and the GitHub Release. One-click download: unzip,
double-click mailpress.exe, done.
- README's "Install" section updated to point at the single
mailpress-installer.zip and shows the file tree of what's inside.
https://claude.ai/code/session_01CfsRS2PZ4t8RUnhPdVEWHF
Audit follow-up: config.example.json is never read at runtime. The wizard creates config.local.json from scratch and the only function that ever referenced the example file (examplePath in lib/config.mjs) had no callers. Removed the file and the dead export. Also removed two other dead exports surfaced by the grep: - isConfigured in lib/config.mjs — never called - SCOPES re-export in lib/oauth.mjs — only used internally Install bundle is now down to exactly three files: mailpress.exe (the app + embedded icon) print-files.ps1 (runtime helper; lib/printer.mjs invokes it) INSTALL.txt (paper install guide) Removed from the install bundle: - config.example.json — wizard creates the config; no one needs the template - mailpress.ico — icon already embedded in the exe; the loose .ico only matters if you want to pin a custom shortcut INSTALL.txt updated to list the actual contents + the auto-generated files that appear after the wizard runs. https://claude.ai/code/session_01CfsRS2PZ4t8RUnhPdVEWHF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
File audit: Removed
assets/icon-preview-256.png(only ever used once to show you the icon — not consumed by build or runtime). Everything else in the repo (cli.mjs, the 11 files inlib/,print-files.ps1,config.example.json,assets/icon.{svg,ico},scripts/build.mjs,.github/workflows/release.yml) has a clear single role.Install bundle:
scripts/build.mjsnow writesdist/INSTALL.txt— plain-text install guide + command reference, so anyone who unzips the bundle has everything they need on paper without internet..github/workflows/release.ymlzipsdist/intomailpress-installer.zip(PowerShellCompress-Archive) and attaches it to both the workflow artifact and the GitHub Release. One-click download, unzip, double-clickmailpress.exe.README.mdinstall section updated to point at the single zip and shows what's inside.After this lands, tagging
v0.1.0on main will trigger CI to publish a release withmailpress-installer.zipas the primary download.Test plan
node scripts/build.mjsproduces dist/ withINSTALL.txtincludedv0.1.0, confirm release page showsmailpress-installer.zipas a single downloadhttps://claude.ai/code/session_01CfsRS2PZ4t8RUnhPdVEWHF
Generated by Claude Code