Skip to content

feat(distribution): publish hardened sample catalog - #17

Merged
kraus-it merged 5 commits into
mainfrom
codex/template-distribution-slice-3
Aug 8, 2026
Merged

kraus-it merged 5 commits into
mainfrom
codex/template-distribution-slice-3

Conversation

@kraus-it

@kraus-it kraus-it commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • harden the remaining eleven existing samples for independent template distribution
  • package all fourteen ready templates deterministically with pinned build metadata
  • remove raw-token UI and require validated OIDC identity before establishing sessions
  • add lockfiles, ignore rules, generated CI, and catalog-wide packaging regression tests

Validation

  • distribution manifest: 20 templates (14 ready, 6 planned)
  • distribution tests: 15/15 passing
  • React/Lovable/Vue/Angular production builds passing
  • Android debug build, Flutter analyze, Swift parse passing
  • Express, Flask, Go, PHP, Laravel checks passing
  • production dependency audits clean where supported

Review policy

This PR intentionally remains open. Later slices are stacked on top of it until the six-slice epic is complete.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@kraus-it

kraus-it commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@claude Please review this PR, including the distribution safety boundaries, generated satellite repositories, and OIDC session establishment changes. Do not modify files; report actionable findings.

@kraus-it

kraus-it commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Slice 3 validation complete:

  • 16/16 distribution tests passing; 20-template manifest valid
  • all 11 new satellites verify byte-for-byte against source commit 4230326
  • fresh-clone builds pass for Lovable, Vue, Angular (Node 24.15), Android, iOS, Flutter, Express, Flask, Go, PHP, and Laravel (Composer container)
  • Claude workflow was triggered, but the run explicitly reports that CLAUDE_CODE_OAUTH_TOKEN is not configured; no Claude findings were produced

This PR remains intentionally open while Slice 4 is stacked on it.

@kraus-it

kraus-it commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

@claude Please review the current head of this PR. Focus on correctness, security, distribution/sync behavior, reproducibility, and tests. Report only actionable findings; if clean, state that explicitly.

@kraus-it

kraus-it commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4230326da1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread auth_samples_python/README.md Outdated
Comment thread auth_samples_python/app.py
Comment thread auth_samples_go/main.go
@kraus-it

kraus-it commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

Review follow-up complete on current head 9ba2b97.\n\nAddressed all three open Codex threads:\n- Flask now uses a server-side Flask-Session CacheLib store; only an opaque session id is cookie-backed.\n- Token/UserInfo session state is committed only after UserInfo succeeds, with defensive cleanup on failure.\n- Go preserves the UserInfo error while clearing one-time OAuth state.\n\nThe earlier local Claude review findings are also included in 513d472. Verification: clean Python 3.13 install/import/session smoke test, Go 1.25 test/build, and 16/16 Slice 3 distribution tests. A local Claude re-review explicitly confirmed the three fixes and found no remaining blocking correctness or security issue.\n\nAll review threads are resolved. The PR remains open as requested.

@kraus-it
kraus-it merged commit 8f88754 into main Aug 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant