Closes the two open Phase 2 items and adds the custom-instruments fol… - #114
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…low-up.
feat: phase 2 sample re-sourcing + custom-instruments second pass
Sample re-sourcing (7 of 13 synth-only voices restored, all velocity-layered):
(Sullivan Wurlitzer EP200 + Pianet T, CC-BY 3.0), string ensemble
(VSCO 2 CE, CC0), sourced via the sfzinstruments org's SPDX-tagged libs.
remapped F3–E6 and re-rendered. New sampleManifests.test.ts guards every
set's pitch span so an octave slip fails CI instead of ears.
verified by measuring the fundamental), per-note gain, stale-output pruning.
Custom instruments (second pass):
filename-matched import, synth-kit fallback for unfilled pieces.
Docs: roadmap, LICENSE_AUDIT, DATA_LICENSES, custom-instruments-design updated.