feat/time-signature-foundation - #117
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-4/4 time signatures: Meter model + generation-core threading (milestone 1)
Foundation for 3/4, 6/8, 7/8 (and other meters). This milestone makes the
whole pipeline meter-aware while keeping 4/4 byte-identical; the per-generator
within-bar feel for non-4/4 is milestone 2 (see docs/roadmap.md).
in quarter-beats: 4/4->4.0, 3/4->3.0, 6/8->3.0, 7/8->3.5), compound/odd
detection, and pulse positions. All positions stay in quarter-beats, so the
one thing that varies is bar_beats and every
bars * 4becomesbars * bar_beats(== 4.0 for 4/4, hence unchanged).BuildSongRequest, and RegeneratePartRequest; bad input falls back to 4/4.
(compound meters click on the dotted quarter); 4/4 meta unchanged.
already used a local beats_per_bar), _plan_sections, and the section loop.
4/4 stays byte-identical — 135 backend tests green, ruff clean. Non-4/4 runs
end-to-end with correctly-sized bars and MIDI meta.
Known limitation (milestone 2): generators still place some notes at fixed
within-bar offsets that overflow shorter bars (walking-bass beat 4, the drum
16-step grid), so non-4/4 output is structurally correct but not yet
rhythmically finished. No UI selector yet, so 4/4 is the only reachable meter
from the app — this milestone is safe to ship.