feat/phase4-features-and-polish - #120
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 — features & polish
Completes Phase 4 of the roadmap, plus two UX fixes surfaced during
ear-validation. All backend (223) and frontend (123) tests green; 4/4 and
default-song output stay byte-identical.
Tempo automation (roadmap item)
tempo_automationknob (0–1) scales the song tempo map — chorus push,pre-chorus lean, ending ritardando — via
m = intensity/0.5: 0 = flat,0.5 = the classic subtle default (byte-identical), 1 = expressive.
through build + melody-upload + every regen/replay path and persisted in
song_meta.jsonso re-rolls stay sample-locked. (Mid-song key modulation —chorus/bridge/final-chorus shifts — was already shipped.)
Progression picker (bonus)
(roman numerals + resolved chords), a saved library, or free-text custom —
consolidating the old Advanced-only field.
style/key.
list_styles/StyleInfonow exposeprogression_templates.Surface WAV/offline export (roadmap item)
(
⏬ WAV/⏬ Stems (WAV), accent-styled) from MIDI (ZIP downloads), soaudio export reads as a first-class action instead of a cryptic
⚡.Loop playback (bonus)
toggle()takes a loop hint threaded via ExportPanel (mode) and SongResult.Idiomatic non-4/4 drums + meta fix
eighth grid grouped in threes. 4/4 stays byte-identical.
metertowrite_midi/write_combined_midi, sothe
.midtime_signature meta matches the request instead of always 4/4.Priors toggle (roadmap item)
hint when no prior exists) instead of self-hiding.