MAT4 Loading#1698
Merged
Merged
Conversation
- Properly load all MAT4 data New fields/inlines/structs are based on what HD does. Still looking for ways to clean things up, particularly getMatInitData.
- Checking the values in the debugger reminded me that these need to be swapped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still working on cleanup, might change how some of this is implemented.
Does not change anything in-game until Aurora allows specifying depth bias (not something GX seems to support, at least not in the same way as GX2), would wait to merge this until both changes are complete and can be tested properly.