Change default log level from DEBUG to INFO#1761
Open
GiorgioMendieta wants to merge 2 commits into
Open
Conversation
|
Does this still write at debug level into the .log files? Those would still be useful, but being able to limit system journal spam is definitely needed. |
Contributor
Author
No, log files are written at INFO level by default with this change, unless you specify the DEBUG log level with the flag I still think it is a sensible default for most users. If needed the log level can be changed to DEBUG (or other levels) for development or debugging. This prevents creating huge log files as well depending on the playtime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes default log level from 0=LOG_DEBUG to 1=LOG_INFO, preventing cluttering the journal.
I think this is useful for end users, during development devs can just open the app with the
-l 0flag anyways.Closes #1000