Skip to content

Allow Sun's Song & Quick Transform to be bound via the Custom Action …#1784

Open
sera-phie wants to merge 2 commits into
TwilitRealm:mainfrom
sera-phie:main
Open

Allow Sun's Song & Quick Transform to be bound via the Custom Action …#1784
sera-phie wants to merge 2 commits into
TwilitRealm:mainfrom
sera-phie:main

Conversation

@sera-phie
Copy link
Copy Markdown

@sera-phie sera-phie commented May 24, 2026

…Bindings menu along with default.

This is for people that get irritated with not being able to hit the buttons at the exact same time, without also requiring that Midna be rebound.

EDIT: I guess that this isn't needed like at all since it's not a timing thing at all and it was digital triggers messing things up for me, so this basically doesn't need to be done at all. Can use it if you want to though as a general convenience thing.

EDIT: Added moon jump as well, and disabled the default binds when new ones in Custom Action Bindings are bound

@Abzol
Copy link
Copy Markdown
Contributor

Abzol commented May 24, 2026

Rather than

if (mDoCPd_c::getHoldR(PAD_1) && mDoCPd_c::getTrigX(PAD_1) ||
    IF_DUSK(dusk::getActionBindTrig(dusk::ActionBinds::SUN_SONG, 0))) {

Maybe something like

if (dusk::getActionBindTrig(dusk::ActionBinds::SUN_SONG, 0) ||
   (dusk::getActionBindButton(dusk::ActionBinds::SUN_SONG, PAD_NATIVE_BUTTON_INVALID) &&
    mDoCPd_c::getHoldR(PAD_1) && mDoCPd_c::getTrigX(PAD_1))

(I havent actually tested if this works)

@Abzol
Copy link
Copy Markdown
Contributor

Abzol commented May 24, 2026

my bad you want to use dusk::isActionBound(dusk::ActionBinds::<action bind>, 0, not compare to button_invalid

@MelonSpeedruns
Copy link
Copy Markdown
Collaborator

I think this is neat, but it should probably wait until we put in place a system where action bindings can be mapped to more than 1 button to create a button combo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants