Fix King Bublin Overflow#1899
Open
korrectional wants to merge 6 commits into
Open
Conversation
PJB3005
requested changes
May 29, 2026
Member
PJB3005
left a comment
PJB3005
left a comment
There was a problem hiding this comment.
This really should be a clamp in the spot that's actually overflowing.
Contributor
Author
|
This time I capped everything where it will actually flow. Ia ctually included 2 caps: one in damageMagnification, although the possibilities of the overflow happening there are remote at best, and one in setDamagePoint where the overflow is likely happening. I also changed the cap and multiplication value to 999.0f like I did in the first commit, while that is not mandatory it seems to be a slightly more standard value. |
Contributor
Author
|
hmm still working on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to issue #1563 . While it might look like a temporary solution, if I remember correctly the maximum amount of health that Link can have is around 200, so multiplying enemy damage by 999 instead of 9999 should still lead to game over while avoiding overflows (or wathever was happening with this specific boss)