Mod loader#453
Draft
qwertyquerty wants to merge 59 commits into
Draft
Conversation
# Conflicts: # CMakeLists.txt
PJB3005
reviewed
Apr 24, 2026
PJB3005
requested changes
Apr 24, 2026
Member
PJB3005
left a comment
PJB3005
left a comment
There was a problem hiding this comment.
Didn't review the hooking code or any of the build stuff yet
Also just some code cleanup
Probably necessary if we're gonna be replacing game files etc
Mods can now replace DVD files with contents of their "overlay" folder (I'll update the docs later when I do a full pass and make non-code mods more of a first-class citizen) Fixes #1306
Unicode fixes
Each mod must have a unique ID
We love RAII
Allows us to re-enable PCH on RmlUI. We'll likely need to rethink how this works anyways IMO.
Avoid funny business.
…registered CVars. Now we store the raw JSON value in memory for unregistered CVars. Intended to be used for mod CVars, as we obviously can't statically define all of those. CVar names are now stored as an std::string, so the lifetime is easy to manage when dynamically registered. CVars cannot be moved/copied anymore. We had some code that was accidentally relying on this, and I fixed that.
We now register a CVar for mod enablement for each mod. Also made LoadedMod stored in unique_ptr because we keep pointers to them already, and I'm entirely uncomfortable with keeping pointers to the vector directly.
…nversions with ranges)
This was for the code mods toggle before I moved the checking logic to CMake.
Avoid config shenanigans
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.