Repository navigation
Keep OkHttp major updates out of automated Dependabot updates - #79
Merged
Merged
Conversation
OkHttp types are part of Lustro's public API, and the published POM depends on OkHttp 4.12.0. Gradle resolves that floor up to the consumer's own OkHttp, so apps on OkHttp 4 and apps on OkHttp 5 both work. A 5.x floor would force OkHttp 5 on every consumer. Also, okhttp-android 5.x needs compileSdk 36, and the build uses 35, so the 5.x bump fails checkDebugAarMetadata. An ignore comment on an earlier OkHttp 5 PR did not stop Dependabot from opening a new one for 5.5.0, so the rule is now in dependabot.yml. It ignores major updates of every com.squareup.okhttp3 artifact (okhttp, mockwebserver, okhttp-tls). Minor and patch updates still arrive, also after a deliberate move to 5.x. Signed-off-by: Evgenii Plokhov <plokhov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ignore major-version Dependabot updates for
com.squareup.okhttp3:*(okhttp,mockwebserver,okhttp-tls) in.github/dependabot.yml.Why
okhttp-android5.x needs compileSdk 36. The build uses 35, so the bump failscheckDebugAarMetadata(this is why build(deps): bump okhttp from 4.12.0 to 5.5.0 #66 and build(deps): bump okhttp from 4.12.0 to 5.4.0 #8 are red).@dependabot ignore this major versioncomment on build(deps): bump okhttp from 4.12.0 to 5.4.0 #8 did not stop Dependabot from opening build(deps): bump okhttp from 4.12.0 to 5.5.0 #66 for 5.5.0. A rule independabot.ymlis permanent and visible in the repository.The rule uses
update-types: version-update:semver-majorinstead of a version range. Minor and patch updates still arrive, also after a later move to 5.x, and the rule does not have to be removed for that.Type of change
Checklist
git commit -sCompatibility notes
None. No change to the library, its API, or the wire protocol.