fixed thumbnail and file link urls in filebrowser due to path change in ...#40
Open
andrewminton wants to merge 4 commits intoTwistedInteractive:masterfrom
Open
fixed thumbnail and file link urls in filebrowser due to path change in ...#40andrewminton wants to merge 4 commits intoTwistedInteractive:masterfrom
andrewminton wants to merge 4 commits intoTwistedInteractive:masterfrom
Conversation
Author
|
2 additions to this PR give us more scope for other upload field types and also fixes the creation of new entries via filebrowser: the enctype="multipart/form-data" was missing from the form in the filebrowser.js Fixed now, hopefully you'll accept these changes. |
… in destination path when JIT is enabled... this way, if a folder deeper in the chain has workspace as it's name it wont get replaced as it would with str_replace.
|
Thanks @andrewminton! |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...upload fields in 2.3.3
I've added the destination folder back into the code so that the link and thumbnail show up correctly in the filebrowser window.
This wasn't working due to the destination being removed from the upload field in recent changes to the core.
See what you think.