Repository navigation
Own player panel instead of miniplayer, smoother player and shorts - #49
Merged
Merged
Conversation
- SlidingPanel replaces the unmaintained miniplayer package: tap and drag on the collapsed bar, no gestures of its own while expanded (no more PanelTapGuard), back collapses the player, stays expanded on rotation. - Video controls ignore pointer events after they were removed mid-gesture. - Player details are built while the panel rests, kept while collapsed, laid out at their expanded height and reused during the transition. - Seek bar repaints from a ValueNotifier and rebuilds once a second. - Hidden tabs and the tab behind the open player stop their tickers. - Cheaper text shadows over the shorts. - Stash's placeholder images (default=true) are not fetched. - List previews play the MP4 preview by default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 3 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SlidingPanel(lib/features/player/sliding_panel.dart) replaces the unmaintainedminiplayerpackage (last release 2021): tap/drag on the collapsed bar, dismiss by dragging it down, no own gestures while expanded (soPanelTapGuardis gone), back collapses the open player (AppShell'sPopScopeinstead of the deprecated scoped will-pop callback), stays expanded when the window height changes, honors reduced motion.ValueNotifierinstead of rebuilding on every mpv position update; hidden tabs and the tab behind the open player getTickerModeoff; cheaper text shadows over the shorts.default=trueURLs) are no longer fetched (removes the Android "Failed to decode image" spam).Tests
sliding_panel_test.dart(19 cases), back/ticker tests inshell_layout_test.dart, seek bar repaint test, controls-removed-mid-gesture test, placeholder URL tests, preview default test.dart analyzeclean,flutter test837 passing. Checked on a Pixel 6 by hand (less jank; shorts only slightly better, likely the full-resolution source files).🤖 Generated with Claude Code