Skip to content

Fullscreen: plain black fade on both platforms, quicker - #53

Merged
Two-Play merged 1 commit into
developfrom
feature/ios-fullscreen-fade
Oct 26, 2026
Merged

Two-Play merged 1 commit into
developfrom
feature/ios-fullscreen-fade

Conversation

@Two-Play

Copy link
Copy Markdown
Owner

Fullscreen: plain black fade on both platforms, quicker

  • Entering and leaving fullscreen (tilting, button, back, holding upright) now fades the whole app to black, turns the screen underneath and fades back in, on iOS and Android. On iOS the moving video (What's new, fullscreen by tilting, calmer shorts, marker editing #52) still turned in view; the plain fade read best on both. The morph stays in the code behind FullscreenMorph.curtainOnlyOverride (and its tests).
  • Quicker for wide videos: settle time 350 → 250 ms, fade out 180 → 120 ms, fade in 300 → 200 ms, and two drawn frames + 50 ms after the turn instead of a fixed 200 ms. Still waits for the window to actually turn (at most 1 s).
  • Android phones cut without the system's rotation animation (ROTATION_ANIMATION_JUMPCUT); the stretched old frame it shows for a moment is under the black. iOS already turns without animation.

Testing

  • dart analyze, flutter test (883 tests, including the fade mode), flutter build apk --debug.
  • Not tried on a device yet; iOS not built locally.

🤖 Generated with Claude Code

The app fades to black, turns underneath and fades back in (the moving video
turned in view on iOS; it stays available behind curtainOnlyOverride).
Shorter fades and settle time, two frames instead of a fixed 200 ms after
the turn, and Android cuts without its own rotation animation.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Two-Play
Two-Play merged commit c178487 into develop Oct 26, 2026
1 check passed
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant