Skip to content

Revert "Fix Shellslug multiplying Daily Corals by 0" #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TwoSpookyBoos merged 1 commit into from
May 21, 2026
Merged

Revert "Fix Shellslug multiplying Daily Corals by 0" #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions mysite/models/advice/generators/general.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,11 @@ def get_upgrade_vault_advice(upgrade_name: str, link_to_section: bool = True, ad
)


def get_companion_advice(companion_name: str, value_is_multi: bool = False) -> tuple[int | float, Advice]:
def get_companion_advice(companion_name: str) -> tuple[int | float, Advice]:
companion_data_missing = not session_data.account.companions['Companion Data Present']
missing_companion_data_txt = '<br>Note: Could be inaccurate. Companion data not found!' if companion_data_missing else ''
companion = companions_data[companion_name]
companion_value = companion['Value'] * has_companion(companion_name)
if companion_value == 0 and value_is_multi:
companion_value = 1
return companion_value , Advice(
return companion['Value'] * has_companion(companion_name), Advice(
label=f"Companions - {companion_name}:"
f"<br>{companion['Description']}"
f"{missing_companion_data_txt}",
Expand Down
2 changes: 1 addition & 1 deletion mysite/w7/coral_reef.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def get_sources_of_coral_info_group() -> AdviceGroup:
base_daily_corals = 10

# Mult A
shellslug_multi, shellslug_advice = get_companion_advice('Shellslug', value_is_multi=True)
shellslug_multi, shellslug_advice = get_companion_advice('Shellslug')

# Mult B
coolral = session_data.account.event_points_shop['Bonuses']['Coolral']
Expand Down
Loading