test(alert-registry): verify updated_at > created_at and 50-rule limit#157
Merged
habiba-d-coder merged 1 commit intoMay 30, 2026
Conversation
- Add test_updated_at_strictly_greater_than_created_at: advances the Soroban ledger timestamp by 1 second between register_alert and update_alert, then asserts updated_at is strictly greater than created_at after the call. - Add test_register_alert_with_50_rules_no_instruction_limit: registers an alert with exactly 50 valid rules (alternating rule:transfer / rule:mint) and confirms all 50 entries are persisted without hitting the Soroban instruction budget.
|
@pugsleyonesimus-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #50
closes #55
Summary
Two new unit tests added to
contracts/alert-registry/src/lib.rs.test_updated_at_strictly_greater_than_created_at
Advances the Soroban ledger timestamp by 1 second between
register_alertand
update_alertusingenv.ledger().with_mut(), then asserts:created_at == updated_atimmediately after registrationupdated_at > created_atstrictly after the update calltest_register_alert_with_50_rules_no_instruction_limit
Registers an alert with exactly 50 valid rules (alternating
rule:transfer/
rule:mint) and confirms:What was tested
setup()helper