fix: emit admin transfer events and add multi-admin support#159
Open
stellajose wants to merge 1 commit into
Open
fix: emit admin transfer events and add multi-admin support#159stellajose wants to merge 1 commit into
stellajose wants to merge 1 commit into
Conversation
Closes Tx-wat#7, closes Tx-wat#22 alert-registry: - emit (admin, transfer) event in transfer_admin for on-chain audit trail - fix update_webhook and remove_alert referencing undefined variable owner - add tests for transfer event and old-admin rejection after transfer watcher-registry: - replace single-admin model with Vec<Address> admin set under DataKey::Admins - fixes broken split between ADMIN and ADMINS keys that broke after transfer - add add_admin: any existing admin can add another (closes Tx-wat#22) - add remove_admin: refuses to remove last admin to prevent lockout - emit (admin, transfer) event in transfer_admin (closes Tx-wat#7) - emit (admin, add) and (admin, remove) events for full audit trail - emit (watcher, remove) event that was previously missing - add get_admins returning full admin set, keep get_admin for compat - add ContractError::LastAdmin = 4 - add 10 new tests covering all multi-admin paths
|
@stellajose Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7
Closes #22
Summary
#7 — transfer_admin emits no event (both contracts)
remove_alert referenced undefined variable
owner(param iscaller)#22 — Single-admin SPOF (watcher-registry)