refactor(watcher-registry): consolidate storage keys to DataKey enum#170
Merged
habiba-d-coder merged 2 commits intoMay 31, 2026
Conversation
- Replace all symbol_short! storage calls with DataKey::Admins / DataKey::Watchers - Fix transfer_admin/load_admins key mismatch (was writing ADMINS, reading ADMIN) - Align initialize to store Vec<Address> under DataKey::Admins Closes Tx-wat#91
|
@deborahamoni0-prog Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #91
Replaces all
symbol_short!storage calls with the existingDataKeyenum variants (DataKey::Admins/DataKey::Watchers), which was defined but never used.Changes
DataKeyinstead of rawsymbol_short!stringstransfer_adminwas writing to"ADMINS"whileload_adminsread from"ADMIN"— admin was lost after transferinitializenow storesVec<Address>underDataKey::Admins, consistent with howload_adminsreads itsymbol_short!retained only for event topic publishing inregister_watcher(not a storage key)