feat(storage): Normalize contract sort order for stable dashboard display#166
Merged
habiba-d-coder merged 1 commit intoMay 31, 2026
Merged
Conversation
… display (Tx-wat#69) - sortContracts<T>(): sort by network rank → label (A–Z, case-insensitive) → id - mainnet before testnet before futurenet; unknown networks sorted last - Pure function — never mutates input; idempotent - Apply in storage.ts on every saveContract() write and getContracts() read - Tests: network priority, label sort, case-insensitive, tiebreaker, immutability, idempotency Closes Tx-wat#69
|
@dreamgenies Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contracts now always return in the same order regardless of insertion sequence: mainnet first, then alphabetically by label, with ID as a deterministic tiebreaker. The dashboard no longer reorders items between saves.
Changes
lib/contractSort.ts:sortContracts<T>()— pure, immutable, idempotent sort functionlib/__tests__/contractSort.test.ts: 8 tests covering all sort paths, immutability, and idempotencyIntegration
In
storage.ts, wrap reads and writes:Closes #69