feat(lib): Add centralised amount formatting helper for consistent token rendering#168
Open
NUMBER72857 wants to merge 1 commit into
Open
feat(lib): Add centralised amount formatting helper for consistent token rendering#168NUMBER72857 wants to merge 1 commit into
NUMBER72857 wants to merge 1 commit into
Conversation
…endering (Tx-wat#105) - formatAmount(): asset-aware decimal places (XLM=7, USDC=2, unknown=7) - formatAmountValue(): label-free variant for table cells with asset header - formatAmountCompact(): K/M abbreviations for dashboard summaries - isZeroAmount(): zero-value predicate - stroops flag: divide by 1e7 for raw Stellar ledger values - 16 unit tests covering all functions, edge cases, and NaN/non-finite input Closes Tx-wat#105
|
@NUMBER72857 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Centralises all amount rendering in
lib/formatAmount.tsso decimal places, locale formatting, and unit labels are consistent site-wide. Replace inlinetoFixed()/ template literal calls inWebhookLog.tsxwith these helpers.Changes
lib/formatAmount.ts:formatAmount(raw, asset, stroops?): full label, asset-aware decimals (XLM=7, USDC=2)formatAmountValue(): number only — for table cells where column header names the assetformatAmountCompact(): K/M abbreviations for summary widgetsisZeroAmount(): zero-value predicate for conditional styling__tests__/formatAmount.test.ts: 16 tests covering all paths, edge cases, stroops conversion, NaNUsage in WebhookLog.tsx
Closes #105