feat(webhook-log): Add ascending/descending date sort controls to alert history#169
Open
NUMBER72857 wants to merge 1 commit into
Open
feat(webhook-log): Add ascending/descending date sort controls to alert history#169NUMBER72857 wants to merge 1 commit into
NUMBER72857 wants to merge 1 commit into
Conversation
…t#103) - useSortedLog<T>(): sort hook with desc/asc toggle, does not mutate source array - Defaults to desc (newest first); malformed timestamps handled without throw - SortToggle component: accessible button with arrow icon and 'Newest/Oldest first' label - 8 unit tests: default sort, asc init, toggle flip, setSortDirection, immutability, empty, bad timestamp Closes Tx-wat#103
|
@NUMBER72857 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a reusable
useSortedLoghook andSortTogglebutton so users can switch between newest-first and oldest-first ordering in the webhook log / alert history.Changes
hooks/useSortedLog.ts: generic sort hook;toggleSort(),setSortDirection(), memoised sorted array; immutable (never mutates source)components/SortToggle.tsx: accessible button with ↑/↓ arrow and label; plugs into any table header__tests__/useSortedLog.test.ts: 8 tests — default sort, direction init, toggle, immutability, empty list, malformed timestampsIntegration into WebhookLog.tsx
Closes #103