feat(contracts): Allow network editing with caution messaging on contract detail page#171
Open
NUMBER72857 wants to merge 1 commit into
Open
feat(contracts): Allow network editing with caution messaging on contract detail page#171NUMBER72857 wants to merge 1 commit into
NUMBER72857 wants to merge 1 commit into
Conversation
…wat#87) - NetworkEditField: inline edit mode with network select; shows alertdialog warning before confirming network change - CAUTION_MESSAGES: per-network explanations of duplicate-detection and alert context side-effects - 'Keep current' dismisses without saving; 'Switch to X' calls onNetworkChange - disabled prop hides Edit button (e.g. during save operations) - 8 tests: render, edit mode, warning content, keep-current, confirm, disabled, cancel Closes Tx-wat#87
|
@NUMBER72857 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Users can now change a contract's network directly from the detail page. A contextual warning dialog explains the impact on duplicate detection and alert history before the change is committed.
Changes
components/NetworkEditField.tsx:alertdialogwarning with network-specific caution message before saveonNetworkChange(network)callback only fires after explicit confirmationdisabledprop for use while parent is saving__tests__/NetworkEditField.test.tsx: 8 tests covering all states and interactionsIntegration in
app/contracts/[id]/page.tsxCloses #87