-
Notifications
You must be signed in to change notification settings - Fork 0
docs(autotrain): step-scaling loss-trend check (64/128 steps), surfaces last_loss noise #1123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
docs/design/autotrain-wf-smoke-20260727-steps128-measured-results.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # autotrain_wf_smoke_20260727_steps128 | ||
|
|
||
| **Honesty:** fixture_or_scratch. **Not ship.** | ||
|
|
||
| train_version=wf_smoke_v2 last_loss=5.877634525299072 stopped_on=steps wall=13.22 record_count=101 seed=0 steps=128 | ||
| example_token_loss_proxy: first_20_mean=65.47187957763671 last_20_mean=3.269563728570938 count=500 | ||
|
|
||
| Independently run in this scheduled autotrain-loop session against `main` HEAD `b908b543` (same already-published `wf_smoke_v2` fixture, no local patch), extending the step-scaling check to 128 steps (seed 0): | ||
|
|
||
| ```bash | ||
| python -m scripts.train_model --train-dir src/slm_training/resources/data/train/wf_smoke_v2 \ | ||
| --model twotower --context-backend scratch --steps 128 \ | ||
| --run-id autotrain_wf_smoke_20260727_steps128 --no-sync-checkpoints --device cpu --seed 0 | ||
| ``` | ||
|
|
||
| Note: `last_loss` (5.88) is *higher* than the 64-step run's `last_loss` (3.92) even though the | ||
| smoothed `example_token_loss_proxy.last_20_mean` kept falling (4.42 -> 3.27) — `last_loss` is a | ||
| single final-minibatch value, not a running average, so it is noisy at this tiny fixture size | ||
| (101 records) and should not be read as a monotonic trend indicator on its own. See the | ||
| step-scaling section of the ledger for the full comparison and interpretation. | ||
|
|
||
| Environment: fresh `.venv` (Python 3.12.3, `torch==2.5.1+cpu`, `pip install -e .`) — | ||
| created in this scheduled session, not committed to the repo (`.venv/` is gitignored). | ||
|
|
||
| `outputs/runs/autotrain_wf_smoke_20260727_steps128/train_summary.json` (not committed; `outputs/` is gitignored). |
19 changes: 19 additions & 0 deletions
19
docs/design/autotrain-wf-smoke-20260727-steps64-measured-results.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # autotrain_wf_smoke_20260727_steps64 | ||
|
|
||
| **Honesty:** fixture_or_scratch. **Not ship.** | ||
|
|
||
| train_version=wf_smoke_v2 last_loss=3.9243931770324707 stopped_on=steps wall=13.13 record_count=101 seed=0 steps=64 | ||
| example_token_loss_proxy: first_20_mean=65.47187957763671 last_20_mean=4.4185902833938595 count=250 | ||
|
|
||
| Independently run in this scheduled autotrain-loop session against `main` HEAD `b908b543` (same already-published `wf_smoke_v2` fixture, no local patch), varying `--steps` from 8 to 64 (seed 0, otherwise identical recipe to `iter1008`-`iter1022`) to check whether the fixture recipe shows a real loss-decrease trend beyond the 8-step smoke probe, rather than just reproducing a fixed single-batch number: | ||
|
|
||
| ```bash | ||
| python -m scripts.train_model --train-dir src/slm_training/resources/data/train/wf_smoke_v2 \ | ||
| --model twotower --context-backend scratch --steps 64 \ | ||
| --run-id autotrain_wf_smoke_20260727_steps64 --no-sync-checkpoints --device cpu --seed 0 | ||
| ``` | ||
|
|
||
| Environment: fresh `.venv` (Python 3.12.3, `torch==2.5.1+cpu`, `pip install -e .`) — | ||
| created in this scheduled session, not committed to the repo (`.venv/` is gitignored). | ||
|
|
||
| `outputs/runs/autotrain_wf_smoke_20260727_steps64/train_summary.json` (not committed; `outputs/` is gitignored). | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: Tyler-R-Kendrick/slm-training
Length of output: 35103
🏁 Script executed:
Repository: Tyler-R-Kendrick/slm-training
Length of output: 36383
Apply the repository’s execution policy to both reproducibility commands.
Both commands document an uncapped
pythoninvocation and omit the approvedMAX_RUN_MINUTES=3run cap source fromsrc/slm_training/levers.py. Use the documented cappedrtkinvocation when available:docs/design/autotrain-wf-smoke-20260727-steps64-measured-results.md#L10-L13docs/design/autotrain-wf-smoke-20260727-steps128-measured-results.md#L10-L13📍 Affects 2 files
docs/design/autotrain-wf-smoke-20260727-steps64-measured-results.md#L10-L13(this comment)docs/design/autotrain-wf-smoke-20260727-steps128-measured-results.md#L10-L13🤖 Prompt for AI Agents
Source: Coding guidelines