Repository navigation
Clear stale quest warnings at login - #143
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saved quest refusals were printed at every login even after the quests had been accepted or completed. Recheck each saved entry against quest state before displaying the report, remove resolved entries, and retain unresolved warnings when client APIs are missing or fail. Prepare version 0.5.2 with matching release notes.
Regression coverage reproduces the stale reports for Zinge's Delivery (1359) and Return to Quinn (430), verifies persistent cleanup and silent login after resolution, and preserves unresolved entries. The regression fails before the fix and passes afterward. Python tests and all Lua suites, including the full race/class simulation, pass using LuaJIT because lua5.1 is unavailable locally. Release validation and the addon build pass. In-game quest history and login behavior remain unverified.