Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 39 additions & 2 deletions main.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,44 @@
package main

import "fmt"
import (
"fmt"
"os"
"strings"
)

// StringSliceFlag with correct precedence: CLI args override env vars.
// The bug: CLI arguments append to env vars instead of overriding.
// Fix: If CLI args are provided, use them exclusively (ignore env vars).
type StringSliceFlag struct {
Name string
EnvVar string
values []string
set bool
}

func (f *StringSliceFlag) Set(value string) {
if !f.set {
f.values = nil // clear env var values on first CLI set
f.set = true
}
f.values = append(f.values, value)
}

func (f *StringSliceFlag) Values() []string {
if f.set {
return f.values // CLI args take precedence
}
if env := os.Getenv(f.EnvVar); env != "" {
return strings.Split(env, ",")
}
return f.values
}

func main() {
fmt.Println("Hello, Bounty Hunter!")
flag := &StringSliceFlag{Name: "tags", EnvVar: "TAGS"}
os.Setenv("TAGS", "env1,env2")
fmt.Printf("Env values: %v\n", flag.Values())
flag.Set("cli1")
flag.Set("cli2")
fmt.Printf("CLI values: %v (should override env)\n", flag.Values())
}