Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
I've been playing Icebreaker (https://sp-mod.com/mod/2866/manimals-icebreaker-backport) and noticed that this mod doesn't work there. This is because the map doesn't have any airdrop point locations, so it fails the
IsFireSupportAvailable()check.I've added a carve-out for Icebreaker specifically.
I've also tested this locally on my machine and it seems to work, though I didn't check too thoroughly as I don't have dev tools set up for this at the moment, but I can confirm I can now call a helicopter cargo transfer onto the map and it shows up and allows me to transfer items.
I've put this PR against
mainbut I know that the most up-to-date code is inrelease/1.3.13. Unsure how you're managing branches on this project but feel free to change the base to any other.