Skip to content

fix: use lzma2 compression instead of lzma2/max in installer - #38

Merged
YSmauas merged 1 commit into
TypesetOK:mainfrom
tsoolgee:fix/installer-slow-compression
Nov 17, 2026
Merged

YSmauas merged 1 commit into
TypesetOK:mainfrom
tsoolgee:fix/installer-slow-compression

Conversation

@tsoolgee

@tsoolgee tsoolgee commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

מה מוזג

שינוי ברירת המחדל של CompressionLevel ב-scripts/installer.iss מ-lzma2/max ל-lzma2.

מדידה אחרי המיזוג

מדדתי ב-windows-latest (מתקין 0.36.1, התקנה שקטה עם לוג) ומצאתי שהשינוי הזה כמעט לא משפיע:

כיווס בנייה גודל התקנה ראשונה
lzma2/max 69.5 שנ' 75 MB 9.1 שנ'
lzma2 57–64 שנ' 75 MB 6.5–8.7 שנ'

לפי הלוג של Inno, רוב זמן ההתקנה הולך על פריסת TypesetOK.exe (168MB), ולא על רמת הכיווס. התיקון שבאמת מקצר את ההתקנה נמצא ב-PR המשך.

Refs #37

lzma2/max is 5-10x slower to build than lzma2 (normal) with minimal
size benefit for Electron bundles, whose Chromium/Node binaries are
already non-compressible. This change keeps the same LZMA algorithm
but drops the ultra-slow max level, so both CI builds and local
developer builds finish in reasonable time.

The CompressionLevel define still lets callers override it via
/DCompressionLevel=... if they need the original behaviour.

Fixes TypesetOK#37

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@YSmauas
YSmauas merged commit 3148d7d into TypesetOK:main Nov 17, 2026
5 checks passed
@tsoolgee tsoolgee changed the title fix: use lzma2 instead of lzma2/max compression in Inno Setup installer fix: compress the installer with zip so it installs about twice as fast Nov 17, 2026
@tsoolgee tsoolgee changed the title fix: compress the installer with zip so it installs about twice as fast fix: use lzma2 compression instead of lzma2/max in installer Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants