Repository navigation
fix: use lzma2 compression instead of lzma2/max in installer - #38
Merged
Merged
Conversation
lzma2/max is 5-10x slower to build than lzma2 (normal) with minimal size benefit for Electron bundles, whose Chromium/Node binaries are already non-compressible. This change keeps the same LZMA algorithm but drops the ultra-slow max level, so both CI builds and local developer builds finish in reasonable time. The CompressionLevel define still lets callers override it via /DCompressionLevel=... if they need the original behaviour. Fixes TypesetOK#37 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
מה מוזג
שינוי ברירת המחדל של
CompressionLevelב-scripts/installer.issמ-lzma2/maxל-lzma2.מדידה אחרי המיזוג
מדדתי ב-
windows-latest(מתקין 0.36.1, התקנה שקטה עם לוג) ומצאתי שהשינוי הזה כמעט לא משפיע:lzma2/maxlzma2לפי הלוג של Inno, רוב זמן ההתקנה הולך על פריסת
TypesetOK.exe(168MB), ולא על רמת הכיווס. התיקון שבאמת מקצר את ההתקנה נמצא ב-PR המשך.Refs #37