Conversation
rijwal
marked this pull request as ready for review
July 14, 2026 08:05
Jugveer-Sandher
approved these changes
Jul 15, 2026
| ] | ||
| } | ||
| }, | ||
| // ========== QUINTUNA BOARDS (remove) ========== |
Contributor
There was a problem hiding this comment.
nit: Wna just delete all the quintuna configs?
| "MIMode": "lldb" | ||
| } | ||
| }, | ||
| // ======================== |
Contributor
There was a problem hiding this comment.
why is this line here
| ] | ||
| }, | ||
| { | ||
| "label": "Build Embedded: PCM (Quintuna)", |
Contributor
There was a problem hiding this comment.
nit: Similarly here wna delete all quintuna configs?
| static char debug_buf[1024]; | ||
| #endif | ||
|
|
||
| void HAL_GPIO_EXTI_Callback(const uint16_t GPIO_Pin) |
Contributor
There was a problem hiding this comment.
Curious, why does this need to be an interrupt instead of the polling we had?
Lucien950
reviewed
Jul 15, 2026
| { | ||
| if (GPIO_Pin == pcm_en_in.getPin()) | ||
| { | ||
| pcm_en_state = pcm_en_in.readPin(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelist
Testing Done
Resolved Tickets