Add caller-prescribed MADCAP groupings (#227). - #233
Merged
Conversation
- Accept MadcapGrouping specs on add_classifier (age default; skip missing columns) - Add 4g notebook: subgroup checks on public data with artificial ethnicity - Small viz/runner fixes for notebook plotting (sharey/show; preserve interactive backend)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visits_dfcolumns viaMadcapGroupingonadd_classifier. Default remains age-only; missing columns are skipped.run_evaluation(sharey/showonplot_data_distribution; do not force Agg over an interactive backend).Closes #227.
Test plan
madcap_groupingsstill writemadcap_by_age.pnguv run pytest tests/test_evaluate.py(new grouping tests)