Add core DSC data-tooling gaps: yq, yamllint, git-lfs, xan, pandoc, shellcheck - #12
Merged
Merged
Conversation
…hellcheck Cross-checked Tim's actual Homebrew leaves against what the script installs. These five are things DSC/DataSquad staff actually use day to day that weren't in the shared onboarding script: - pandoc: was commented out entirely; turns out it's used directly, not just pulled in transitively via Quarto - yq: YAML sibling to jq (already in script) -- used on project-registry.yaml, Carpentries lesson config.yaml, GH workflows - yamllint: validates the same YAML files - git-lfs: large file support in git, relevant for a data science center's datasets; also runs `git lfs install` after brew bundle so the hooks are actually registered, not just the binary present - xan: fast CSV toolkit, core to DSC's data work - shellcheck: added it myself this session to validate `mac` -- keeping it in the script so future maintainers have it without a manual step (updated the Contributing section's instructions accordingly) Left out as personal-preference rather than DSC-standard: podman (already decided Docker Desktop for the shared script), ollama, ocean of general CLI tools (fzf, neovim, go, etc). Also left out hugo/rbenv and MacTeX/TinyTeX per this round's scope -- can revisit if the Jekyll/Hugo site work or Quarto PDF output becomes a common laptop-setup pain point. Verified with shellcheck (same pre-existing warning set) and brew bundle check (all names resolve).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11, which you merged before this last commit landed on the branch.
Cross-checked your actual Homebrew leaves (
brew leaves) against what the script installs, per your request to evaluate the tools in use, not just the version drift. Five gaps you confirmed as worth adding:pandoc: was commented out entirely in the old script; you have it as a standalone leaf, not just riding in as a Quarto dependencyyq: YAML sibling tojq(already in the script) — used onproject-registry.yaml, Carpentries lessonconfig.yaml, GitHub workflow filesyamllint: validates the same YAML filesgit-lfs: large file support in git, relevant for DSC's datasets — also runsgit lfs installafterbrew bundleso the hooks are actually registered, not just the binary presentxan: fast CSV toolkit, core to DSC's data workshellcheck: I installed this myself to validatemacduring the Modernize toolchain: drop Anaconda, add VSCodium/Miniforge/Node/Quarto #11 review — keeping it in the script so future maintainers have it without a manual step; updated the Contributing section's instructions to matchLeft out as personal-preference rather than DSC-standard (your call, not mine):
podman(already decided Docker Desktop for the shared script),ollama, and general CLI tools (fzf,neovim,go, etc). Also left outhugo/rbenv(for the Jekyll/Hugo sites) and MacTeX/TinyTeX (for Quarto PDF output) — flagged as open questions rather than added, since I wasn't sure those are common enough pain points to bake into a shared onboarding script yet.Test plan
shellcheck -s sh mac— same pre-existing warning set, nothing newbrew bundle check— all formula names resolve