[ALL-5963] ci: adopt run-gemini-cli PR review - #37
Open
marshallrobinson wants to merge 3 commits into
Open
marshallrobinson wants to merge 3 commits into
marshallrobinson wants to merge 3 commits into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Review Summary
I have reviewed the changes introduced in this pull request and found them to be correct, secure, and aligned with repository standards.
What was checked:
-
GitHub Actions Workflow (
.github/workflows/pr-review.yml):- Trigger Conditions: The
pull_requesttypes and theissue_commenttrigger are correctly defined. - Safety Condition: The conditional statement
github.event_name != 'issue_comment' || github.event.issue.pull_request != nullproperly ensures that the workflow only runs on pull request comments and not standard issue comments. - Permissions: The permissions block restricts scopes appropriately (
contents: read) while providing the required capabilities (id-token: write,pull-requests: write,issues: write) for Vertex/OIDC integration and automated reviewing. - Reusable Workflow: The workflow references the correct organization-level reusable review workflow (
UGS-GIO/ugs-gha-pr-review/.github/workflows/review.yml@v1) and correctly passes secrets viasecrets: inherit.
- Trigger Conditions: The
-
PR Review Rubric (
GEMINI.md):- The review guide is tailored well to this dormant legacy application, focusing on minimizing modernizations, preventing hardcoded credentials/tokens in client-side JS/HTML, avoiding DOM/XSS injection on feature popups, and ensuring fetch/query failures fail loud.
No defects or security issues were found. The configuration is ready to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the org's automated PR reviewer (run-gemini-cli on Vertex) to
forgeApp— a thin caller thatuses: UGS-GIO/ugs-gha-pr-review/.github/workflows/review.yml@v1plus a repo-tailoredGEMINI.mdrubric. No per-repo secrets (org Actions vars are set). Auto-reviews non-draft PRs from org members/collaborators; anyone else can opt in with/review. Part of the org-wide rollout (umbrella ALL-5570).