Skip to content

Hotfix bbcode regex#5

Open
alexdryden wants to merge 9 commits intomasterfrom
hotfix_bbcode_regex
Open

Hotfix bbcode regex#5
alexdryden wants to merge 9 commits intomasterfrom
hotfix_bbcode_regex

Conversation

@alexdryden
Copy link

No description provided.

This fixes a number of issues with the substitution parsing. If
further work is needed, we should investigate a library like
github.com/chriskonnertz/bbcode.

This commit includes fixes for:
-match only matching tags
-fix substitution syntax
-allow https
alexdryden and others added 2 commits March 22, 2026 13:31
Co-authored-by: graykr <graykr@users.noreply.github.com>
@alexdryden
Copy link
Author

I think ideally we would not call this bbcode_to_html because it doesn't produce html, but that probably isn't really strictly necessary.

@graykr After applying your suggestions I was getting some double mailto:mailto. Probably the easiest way to make sure this is really doing what you expect is to look at the test cases, which I made a bit easier to read. And adding/correcting any mistakes in the test cases might be the clearest way to indicate the expected behavior.

alexdryden and others added 2 commits March 23, 2026 11:43
These are some other ways that email links can appear

Co-authored-by: graykr <graykr@users.noreply.github.com>
@alexdryden alexdryden requested a review from graykr March 23, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants