Open
Conversation
This fixes a number of issues with the substitution parsing. If further work is needed, we should investigate a library like github.com/chriskonnertz/bbcode. This commit includes fixes for: -match only matching tags -fix substitution syntax -allow https
graykr
reviewed
Mar 20, 2026
graykr
reviewed
Mar 20, 2026
graykr
reviewed
Mar 20, 2026
graykr
reviewed
Mar 20, 2026
graykr
reviewed
Mar 20, 2026
Co-authored-by: graykr <graykr@users.noreply.github.com>
Author
|
I think ideally we would not call this bbcode_to_html because it doesn't produce html, but that probably isn't really strictly necessary. @graykr After applying your suggestions I was getting some double mailto:mailto. Probably the easiest way to make sure this is really doing what you expect is to look at the test cases, which I made a bit easier to read. And adding/correcting any mistakes in the test cases might be the clearest way to indicate the expected behavior. |
graykr
reviewed
Mar 23, 2026
These are some other ways that email links can appear Co-authored-by: graykr <graykr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.