203 Client disconnect exception#205
Open
simonoakesepimorphics wants to merge 3 commits intotech/major-security-updatesfrom
Open
203 Client disconnect exception#205simonoakesepimorphics wants to merge 3 commits intotech/major-security-updatesfrom
simonoakesepimorphics wants to merge 3 commits intotech/major-security-updatesfrom
Conversation
der
reviewed
Nov 20, 2025
Contributor
Author
|
Added an interceptor to log the exception as a warning instead. |
der
approved these changes
Nov 20, 2025
Contributor
der
left a comment
der
left a comment
There was a problem hiding this comment.
Nice, didn't realise you intercept any write that way!
Approving now, but see comment on reduce unnecessary log volume.
| context.proceed(); | ||
| } catch (Exception e) { | ||
| if (e.getCause() instanceof ClientAbortException) { | ||
| log.warn("Client interrupted response writer.", e); |
Contributor
There was a problem hiding this comment.
Think this will put the whole exception stack trace in the log which we don't want. Suggest just appending the exception message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from #204
Remap Tomcat internal logs to slf4j.