Fix transcript subscriber delivery#4036
Open
rasmusfaber wants to merge 1 commit into
Open
Conversation
This was referenced May 25, 2026
rasmusfaber
force-pushed
the
event-store-transcript-subscribers
branch
4 times, most recently
from
0fc2d6e to
bd39170
Compare
rasmusfaber
force-pushed
the
event-store-transcript-subscribers
branch
from
bd39170 to
0f9d976
Compare
rasmusfaber
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
What is the current behavior? (You can also link to an open issue here)
Transcript has multiple private subscriber paths with subtly different behavior. Event delivery can become fragile when callbacks re-enter transcript logging or raise exceptions, and duplicate callback registrations are harder to reason about.
What is the new behavior?
Transcript keeps subscription as an internal hook, but uses one consistent multicast implementation. Each subscription gets an independent unsubscribe handle and re-entry guard, and subscriber exceptions are logged without blocking other subscribers or normal transcript processing.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No. This PR does not add a public transcript subscription API; it keeps the hook private and updates internal call sites/tests to use the unified private path.
Other information:
This is PR 1 of 3 in the event-store transcript split. PR 2 (#4037) builds on this private subscriber hook for buffer-backed streaming completion.