Skip to content

CDD-3119 Add a new SimpleMenu model.#3085

Open
djl wants to merge 3 commits intomainfrom
CDD-3119
Open

CDD-3119 Add a new SimpleMenu model.#3085
djl wants to merge 3 commits intomainfrom
CDD-3119

Conversation

@djl
Copy link
Copy Markdown
Collaborator

@djl djl commented Mar 19, 2026

Description

This is a simplified version of the current Menu model where menus are now just simple links with a title.

Fixes #CDD-3119

Type of change

Please select the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tech debt item (this is focused solely on addressing any relevant technical debt)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests at the right levels to prove my change is effective
  • I have added screenshots or screen grabs where appropriate
  • I have added docstrings in the correct style (google)

tushortz
tushortz requested changes Mar 24, 2026
View reviewed changes
Comment thread cms/snippets/models/menu_builder/help_texts.py Outdated
@djl djl force-pushed the CDD-3119 branch 2 times, most recently from 39906dd to a24e41a Compare March 24, 2026 16:03
tushortz
tushortz requested changes Mar 25, 2026
View reviewed changes
Comment thread cms/snippets/views/menu.py Outdated
Comment thread cms/snippets/managers/menu.py Outdated
Comment thread cms/snippets/models/menu_builder/help_texts.py Outdated
Comment thread cms/snippets/serializers/menu.py Outdated
tushortz
tushortz reviewed Mar 25, 2026
View reviewed changes
Comment thread tests/unit/cms/snippets/managers/test_menu.py
@djl djl requested a review from tushortz March 25, 2026 11:23
@aidan aidan marked this pull request as ready for review March 26, 2026 16:24
@aidan aidan requested a review from a team as a code owner March 26, 2026 16:24
aidan
aidan requested changes Mar 26, 2026
View reviewed changes
Comment thread tests/unit/cms/snippets/serializers/test_menu.py Outdated
@djl djl force-pushed the CDD-3119 branch 2 times, most recently from 1496745 to 5295c7c Compare March 27, 2026 10:44
@djl djl requested a review from aidan March 27, 2026 14:23
aidan
aidan approved these changes Apr 2, 2026
View reviewed changes
Comment thread tests/unit/cms/snippets/serializers/test_menu.py
tushortz
tushortz approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tushortz tushortz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@djl djl requested review from aidan and tushortz April 7, 2026 10:51
@djl djl requested a review from aidan April 9, 2026 08:24
@djl djl force-pushed the CDD-3119 branch 2 times, most recently from e1239de to ac842d8 Compare April 9, 2026 10:13
David Logie added 3 commits April 9, 2026 13:43
@djl
CDD-3119 Add a new SimpleMenu model.
c351d2b 
This is a simplified version of the current Menu model where menus are
now just simple links with a title.
@djl
CDD-3119 Add panels attribute to SimpleMenu model.
42e556e
@djl
CDD-3119 Beef up the SimpleMenu serializer tests.
4f81ffb
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 9, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aidan aidan aidan approved these changes

@tushortz tushortz Awaiting requested review from tushortz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@djl @aidan @tushortz