[REFACTOR] 홈 화면 로직 변경#239
Open
kwonminsooo wants to merge 2 commits into
Open
Conversation
4 tasks
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 PR 개요
PUT /home/edit) 하나로 통합하고, 더 이상 쓰이지 않는 기존 코드 정리🛠 변경 사항
PUT /home/edit에서 배경색 변경 + 스티커 배치를 한 번에 저장하도록 통합 (HomeController,HomeService.editHome,HomeEditRequest)StickerController/StickerService/StickerServiceImpl및 관련 요청·응답 DTOSettingController의PATCH /users/me/homecolor,SettingService.updateHomeColor()및 관련 DTOStickerErrorCode,HomeColorErrorCode,UserStickerImageQueryRepository테스트
HomeControllerTest추가: 배경색+스티커 동시 저장, 신규 유저 설정 자동 생성, 재저장 시 기존 스티커 완전 교체, 잘못된 색상 포맷 400, 존재하지 않는 이미지 참조 에러, 미인증 401deleteAllByUserId후 재생성)로 바뀌었는데, 프론트에서 매번 스티커 전체 목록을 보내는 흐름으로 맞춰졌는지 확인 필요✅ 체크리스트