Fix GH-473: Smooth transition for OHM coefficient selection#1048
Draft
Fix GH-473: Smooth transition for OHM coefficient selection#1048
Conversation
Replace step-function coefficient selection with smooth linear blending to eliminate numerical divergence at threshold boundaries. Changes to OHM_coef_cal subroutine: - Add temperature transition zone (±2°C around threshold) - Add moisture transition zones for surface wetness and soil moisture - Blend coefficients from all four conditions (summer/winter × wet/dry) - Add division-by-zero guard for SoilStoreCap This is a physics change that produces more physically realistic results in transition zones. Reference data will need regeneration. Resolves: #473 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
b0349c9 to
ff84a9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces step-function coefficient selection in OHM with smooth linear blending to eliminate numerical divergence at threshold boundaries.
Context
This addresses the root cause of #473 by eliminating the step function entirely. When there's no discontinuity, floating-point precision differences cannot cause different coefficient regimes to be selected.
Before (step function)
After (smooth blend)
Breaking Change
TODO
sample_output.csv.gz)Test plan
Resolves #473
🤖 Generated with Claude Code