fix: unset geometryname for for grib of reduced_stretched_gg gridType#99
Open
bdvllrs wants to merge 1 commit intoUMR-CNRM:2.0.xfrom
Open
fix: unset geometryname for for grib of reduced_stretched_gg gridType#99bdvllrs wants to merge 1 commit intoUMR-CNRM:2.0.xfrom
bdvllrs wants to merge 1 commit intoUMR-CNRM:2.0.xfrom
Conversation
bdvllrs
commented
Mar 30, 2026
| grid['pole_lat'] = Angle(self['latitudeOfStretchingPoleInDegrees'], 'degrees') | ||
| geometryname = 'rotated_reduced_gauss' | ||
|
|
||
| if 'reduced' in self['gridType']: |
Contributor
Author
There was a problem hiding this comment.
I wasn't sure if this could go in the previous if/elif statement L. 1704 or if it needs to come after the if 'stretched', so I didn't change the order.
It there is no order requirements, I will also simplify this by combining the if/elifs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98.
This refactors
epygram.formats.GRIB._read_horizontal_geometryto handle thereduced_stretched_ggcase.The provided changes work when tested on loading a N320 grid.