Repository navigation
Conversation
una-version.sh treated every fatal git rev-parse as dubious ownership. A copied example is not a repository, so the script wrote the error text into the global safe.directory. Only an ownership failure touches that setting, and a failed toplevel is not stored.
|
Warning Review limit reachedThis review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Next included review available in 51 minutes. View limit details
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
una-version.shtreated every failedgit rev-parseas dubious ownership, includingfatal: not a git repository. Configuring a copied example (the path inDocs/sdk-setup.md) then wrote that error text into the globalsafe.directory.Only an ownership failure (
dubious ownershiporunsafe repository) touchessafe.directorynow. Ifgit rev-parse --show-toplevelstill fails after that, the error text is not stored. Version parsing is unchanged.Root cause
Utilities/Scripts/build-cube/una-version.shmatchedfatal:in the same branch as the ownership errors, then rangit config --global safe.directorywith the failed--show-topleveloutput. A copied app directory is not a git repository, so that was the normal result, not an ownership problem.Test plan
bash Utilities/Scripts/build-cube/test_una_version.shbefore the change exited 1. WithGIT_CONFIG_GLOBALpointed at a temp file,safe.directorywas set tofatal: not a git repository (or any of the parent directories): .gitfollowed byfatal: git rev-parse failed.safe.directorywas unset, and stdout containedBUILD_VERSION=0.0.0-dev.GIT_CONFIG_GLOBAL, printedBUILD_VERSION=1.6.2(git describe --exact-matchissdk-v1.6.2on this commit's parent) and did not setsafe.directory.ctest --test-dir build-host --output-on-failure—una-sdk-host-testspassed. Those tests do not run this script.preparejob runsbash Utilities/Scripts/build-cube/test_una_version.sh.