CDA-113 Adding csv support for timeseries#1780
Merged
Merged
Conversation
rma-bryson
force-pushed
the
feature/CDA-113-support-csv-for-time-series
branch
10 times, most recently
from
7219b05 to
8465b44
Compare
rma-bryson
force-pushed
the
feature/CDA-113-support-csv-for-time-series
branch
from
8465b44 to
76e0901
Compare
MikeNeilson
requested changes
Jun 18, 2026
MikeNeilson
left a comment
MikeNeilson
left a comment
Contributor
There was a problem hiding this comment.
Generally good. Definitely concerned about some critical logic duplication.
Collaborator
Author
Was able to get the example csv working
|
MikeNeilson
previously approved these changes
Jun 22, 2026
MikeNeilson
left a comment
MikeNeilson
left a comment
Contributor
There was a problem hiding this comment.
Nice trick with the getExample method to fill out that detail.
Seems within that we could also setup our own annotation to retrieve a sample JSON.
rma-bryson
force-pushed
the
feature/CDA-113-support-csv-for-time-series
branch
from
4f0cc79 to
9f402f6
Compare
MikeNeilson
requested changes
Jun 23, 2026
rma-bryson
force-pushed
the
feature/CDA-113-support-csv-for-time-series
branch
from
9f402f6 to
ab100dc
Compare
MikeNeilson
requested changes
Jun 23, 2026
MikeNeilson
previously approved these changes
Jun 24, 2026
MikeNeilson
left a comment
MikeNeilson
left a comment
Contributor
There was a problem hiding this comment.
Sorry, apparently I merged something in that caused a conflict in this PR.
rma-bryson
force-pushed
the
feature/CDA-113-support-csv-for-time-series
branch
2 times, most recently
from
eaa3133 to
d55690a
Compare
Collaborator
Author
Rebased, ready to merge once approved |
…Moved CsvOnDemandInputStream into its own file. Removed redundant unit conversion logic. Added csv example generator.
…nvalid requested units gracefully.
…handle invalid requested units gracefully." This reverts commit 9f402f6.
…re the data query, eliminating any per-row conversion overhead while still failing fast on invalid units.
…ists to guarantee failure is units
rma-bryson
force-pushed
the
feature/CDA-113-support-csv-for-time-series
branch
from
d55690a to
892b6a0
Compare
MikeNeilson
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements csv support for timeseries. This should also streamline other data types supporting our custom csv formatting in the future - including metadata comment headers at top of payload, unit in column header, and optional-column inclusion via DTO annotations in the spirit of Jackson.
This also adds support for specifying date-format. Currently this only works for csv, but could be extended to other formats in the future.
Also noting decision during cda dev meeting to use query parameters for optional column inclusion and date-format. Updated ADR to reflect that.
Related Issue
Closes #1257
Validation
Added unit tests and integration tests
Checklist