Initial batch. No functional changes other than a System.out to Logger.#1805
Initial batch. No functional changes other than a System.out to Logger.#1805MikeNeilson wants to merge 1 commit into
Conversation
MikeNeilson
force-pushed
the
task/fix-formatting-batch-1
branch
from
5512197 to
4112f15
Compare
There was a problem hiding this comment.
I would remove this package lock. I think it's a bit of leftover.
This is minor, just mentioning
I'm also seeing some trailing whitespace issues in
OfficeFormatV1.java
DateUtils.java
ResourceHelper.java
I thought we had a .gitattributes to help but I'm probably thinking of another repo
There was a problem hiding this comment.
We should remove this because it does not appear the packages are also being updated. Even then it looks unrelated to the rest of your PR.
I suspect you had an old lock file and have not ran npm install in the CDA gui dir and this is resulting in a previous lock file trying to commit?
| public String getInstanceCharset() { | ||
| return instanceCharset; |
There was a problem hiding this comment.
Are there tests this could break renaming the getter here?
Rest looks formatting related but this is an API change
3 participants
Summary
Fix formatting according to Checkstyle results.
Related Issue
N/A
Validation
run
./gradlew checkstyleMainuntil no results for a file in the output. (with a few exception.)Checklist