API for docker container and volumes by elwincheng · Pull Request #22 · UTMIST/Mist

elwincheng · 2025-08-17T16:17:22Z

elwin@DESKTOP-46267GC:~/dev/Mist/src/images$ go test
2025/09/15 18:52:19 WARN Volume does not exist volumeName=nonexistent_volume_t4
2025/09/15 18:52:21 ERROR Failed to remove volume volumeName=test_volume_t5 error="Error response from daemon: remove test_volume_t5: volume is in use - [b3dc76981255bcae4547ef997970146d478c2c8dcb5ed1f88f44c69a48d8412a, ec89342dfcb1a93ae63f0b0ad93b3d38cfa0b7ee1561825a7e34f8f3f53269cf]"
2025/09/15 18:52:30 ERROR Failed to remove volume volumeName=test_volume_t5 error="Error response from daemon: remove test_volume_t5: volume is in use - [b3dc76981255bcae4547ef997970146d478c2c8dcb5ed1f88f44c69a48d8412a]"
2025/09/15 18:52:53 ERROR Failed to remove volume volumeName=test_volume_t7 error="Error response from daemon: remove test_volume_t7: volume is in use - [6cb2b2cc2d799d0e89b5598a0d1df347cde053e485def4c0d7ba14e187d12acc, 1f00b4847e15778db0976b305976981b5a8d49e2821fa6af0ce1f583ab645d92, 8826fc56492f60d4f60bd3e79311dc9d317320da3e0fb3d6d682ba80694f8a19]"
2025/09/15 18:53:14 WARN Volume limit reached limit=100
2025/09/15 18:53:22 WARN Container limit reached limit=10
2025/09/15 18:54:59 ERROR Failed to remove volume volumeName=test_volume_t10 error="Error response from daemon: remove test_volume_t10: volume is in use - [da4c01ee51ae2939f5f6935f04cdb0c93ef125d5910432b81b35cd664e030243, c2cd99981648f58a85ac61857d14c1139f690ba9da335448cd58d4e4214344ec, d46c023de92057fa0f5984500be0f55185f101830f2274e7be3a38c6128bfe7d, a25e7bcac907360331392f5f1a19b4a49dff798193f1ffb64a0f116e59888313, 315aebee4f5aa3f5e9f98a21b0ca0cbca439c44bde3cd4a811c741a52561f0f6, 18a9cbbf388cfd72a83be637deeae7ddd11bbf33f7aeb3fa8acfa0b5d51ef42b, c0e8771cf2583b1187a713a114c183a78d234ec9b819d405b92a383dd91a7346, 1e7a8bb38c07e3887968490c819439778cf8ba076643316736970708697a99dc, 4e8c0a7bd18bbca04f1cd509ee575f1e26bdab78109d4970dd0a4f5cc850b2b8, 34667eb684c077cae995c5a6177c8d9687fff2c8561822cdf470c61a8cbacac2, d5245332e4b810511144700cf1c14ee5be590da05f0e79dbb101d5b81e5da54a, 2155a5d5af438b0656ca81521ade194ac3dc15df46692b67fce66a4040e3b842, 1552b023fabbcc0c7994738e375398ce6b9a26b1015833231131965b54c783bc, 6290884ae1e77e0f0e6bf88717342f18eb848395cea64fecb31d7bb5e69c51c3]"
PASS
ok mist/images 170.630s

KCui0327

Good job! General Comments:

Push changes in go.mod and go.sum
Please provide documentation on the APIs and the existing test plans
Add some comments in the code for logic that may be tricky to understand or ambigious
Add more logging messages (i.e. if we enter error branch, we should log explicitly what is the error)
Avoid using panic for code that will go into prod. but rather handle them in the caller

src/images/serve_image.go

KCui0327 · 2025-08-19T23:22:28Z

src/images/serve_image.go

+	}
+}
+
+func (mgr *ContainerMgr) stopContainer(containerID string) {


I think we should return status when stopContainer exits

src/images/serve_image.go

blobcode

Overall: looks ok; though should probably be relocated / better integrated under the supervisor, esp. ContainerMgr (probably out of scope for this PR though)

src/images/serve_image.go

KCui0327

You still need add race condition protections on volumes and containers.
For next iterations, please do not amend your changes and force push, this makes it hard for reviews to look for diffs since last review

src/images/serve_image.go

elwincheng · 2025-09-07T01:02:20Z

You still need add race condition protections on volumes and containers.

@KCui0327 Sorry I am not understanding. I am acquiring and releasing a mutex lock when calling volume/container functions.

KCui0327 · 2025-09-07T01:04:25Z

You still need add race condition protections on volumes and containers.

@KCui0327 Sorry I am not understanding. I am acquiring and releasing a mutex lock when calling volume/container functions.

ah I see it now, I saw there was no diff in the review so I thought you didn't add it, I will re-review my apologies. But yeah I think for next iterations, please do not amend then force push, it makes it hard to see diffs between revisions

src/images/serve_image.go

KCui0327

Add docstrings
include log file containing the output of the unit tests

src/images/README.md

KCui0327 · 2025-09-11T16:18:09Z

src/images/README.md

+
+---
+
+### `func (mgr *ContainerMgr) runContainerCuda(volumeName string) (string, error)`


there is no runContainerCuda in the code, could you please double check

Thanks that is a good catch

src/images/serve_image.go

KCui0327

Should be last change, need to include proper logging that was committed Tara, refer to the documentation. Provide proper logging in the API and levels

src/images/README.md

src/images/go_test.log

elwincheng · 2025-09-15T22:58:21Z

I had to force push because I rebased off main cause I thought I needed Tara's commit for slog mb.

blobcode · 2025-09-23T18:29:48Z

src/images/serve_image_test.go

+	return NewContainerMgr(cli, 10, 100)
+}
+
+// T1: create a volume, check exists, delete, check not exists


don't number these

blobcode · 2025-09-23T18:30:20Z

src/images/serve_image.go

+		return "", fmt.Errorf("volume %s does not exist", volumeName)
+	}
+
+	resp, err := cli.ContainerCreate(ctx, &container.Config{


fix formatting

blobcode · 2025-09-23T18:32:19Z

src/images/serve_image.go

+		return resp.ID, err
+	}
+
+	io.Copy(os.Stdout, out)


don't dump container output to console - @KCui0327 should be another task to log this better? - we probably want container logs user accessible, no?

Yes that is correct, we can add that in a separate PR

blobcode · 2025-11-17T21:53:04Z

@elwincheng could you please address the existing comments so we can merge this?

elwincheng · 2025-11-18T01:10:39Z

@elwincheng could you please address the existing comments so we can merge this?

I have already addressed @KCui0327 requested changes, and I have re-requested his review. I think after he approves then we can merge?

elwincheng requested review from KCui0327, ambroseling, blobcode and ibrah-m August 17, 2025 16:17

KCui0327 requested changes Aug 19, 2025

View reviewed changes

KCui0327 assigned elwincheng Aug 19, 2025

KCui0327 mentioned this pull request Aug 19, 2025

[WIP] Elwin dev container #19

Closed

blobcode requested changes Aug 20, 2025

View reviewed changes

src/images/serve_image.go Outdated Show resolved Hide resolved

src/images/serve_image.go Outdated Show resolved Hide resolved

src/images/serve_image.go Show resolved Hide resolved

src/images/serve_image.go Show resolved Hide resolved

elwincheng force-pushed the elwin_dev_container_squashed branch from 641739c to 258ce6e Compare September 3, 2025 19:09

github-actions bot added the size/xl label Sep 3, 2025

KCui0327 requested changes Sep 5, 2025

View reviewed changes

src/images/serve_image.go Outdated Show resolved Hide resolved

ibrah-m reviewed Sep 8, 2025

View reviewed changes

src/images/serve_image.go Outdated Show resolved Hide resolved

KCui0327 requested changes Sep 11, 2025

View reviewed changes

elwincheng requested review from KCui0327 and blobcode September 11, 2025 21:54

KCui0327 requested changes Sep 11, 2025

View reviewed changes

src/images/README.md Show resolved Hide resolved

src/images/go_test.log Outdated Show resolved Hide resolved

elwincheng added 9 commits September 15, 2025 18:28

API for docker container and volumes

fea4fc6

remove main function

cb98797

Update readme to reflect latest

086dab5

remove redundant comment

59596cd

Docstrings

0e5050f

go test log

993f0a1

add volume check before creating container

270f046

Add slog

207de8a

remove log output

5f9b42f

elwincheng force-pushed the elwin_dev_container_squashed branch from 271c05d to 5f9b42f Compare September 15, 2025 22:57

blobcode requested changes Sep 23, 2025

View reviewed changes

blobcode mentioned this pull request Sep 29, 2025

API to Create Jobs #65

Open

elwincheng added 2 commits September 29, 2025 19:18

remove test numbering

c280086

format arguments

7256dba

elwincheng requested review from KCui0327 and blobcode October 7, 2025 00:07

blobcode approved these changes Nov 17, 2025

View reviewed changes

KCui0327 approved these changes Jan 13, 2026

View reviewed changes

elwincheng merged commit 804b7e6 into main Jan 13, 2026
1 check passed


		---

		### `func (mgr *ContainerMgr) runContainerCuda(volumeName string) (string, error)`

Conversation

elwincheng commented Aug 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KCui0327 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

KCui0327 Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

blobcode left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KCui0327 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elwincheng commented Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KCui0327 commented Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

KCui0327 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

KCui0327 Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

elwincheng Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KCui0327 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

elwincheng commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blobcode Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

blobcode Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

blobcode Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

KCui0327 Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

blobcode commented Nov 17, 2025

Uh oh!

elwincheng commented Nov 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

elwincheng commented Aug 17, 2025 •

edited

Loading

elwincheng commented Sep 7, 2025 •

edited

Loading

KCui0327 commented Sep 7, 2025 •

edited

Loading

elwincheng commented Sep 15, 2025 •

edited

Loading